Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(messenger-feed): re-position and fix waypoint for visibility and trigger loading more posts in feed view #2279

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(messenger-feed): re-position and fix waypoint for visibility and trigger loading more posts in feed view #2279

merged 1 commit into from
Sep 13, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Sep 13, 2024

What does this do?

  • This ensures the Waypoint is properly visible and triggers the fetchMore function to load more posts in the feed view.

Why are we making this change?

  • The Waypoint was not triggering as expected due to insufficient DOM presence, causing posts to not load as the user scrolled to the bottom of the feed.

How do I test this?

  • run tests as usual
  • check feed UI renders more posts when scrolling to bottom of fetched posts

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team September 13, 2024 11:18
@domw30 domw30 changed the title fix(messenger-feed): re-position waypoint for visibility and trigger loading more posts in feed view fix(messenger-feed): re-position and fix waypoint for visibility and trigger loading more posts in feed view Sep 13, 2024
@domw30 domw30 merged commit 4f89e68 into main Sep 13, 2024
5 checks passed
@domw30 domw30 deleted the fix/waypoint-visibility-and-trigger-for-loading-more-posts-in-feed-view branch September 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30